Include specs in var-meta #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Sep 3, 2019
test/orchard/meta_test.clj
Outdated
| [clojure.test :refer :all])) | ||
| [clojure.test :refer :all] | ||
| [clojure.set :as set] | ||
| [clojure.spec.alpha :as s])) |
There was a problem hiding this comment.
The spec code should be conditionally added, as we still support Clojure 1.8.
There was a problem hiding this comment.
yeah just saw the test matrix failure. I'll get to this tonight.
Wasn't threaded before so the value was computed and thrown away.
dpsutton
force-pushed
the
fix-spec-meta
branch
from
d4fd107
to
710659f
Compare
|
@bbatsov good to go |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't threaded before so the value was computed and thrown away.
Before submitting a PR make sure the following things have been done:
Keep in mind that new orchard builds are automatically deployed to Clojars
once a PR is merged, but only if the CI build is green.
Thanks!