Add handling for java version strings with $OPT chunks #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Jan 31, 2020
| @@ -92,7 +92,8 @@ | |||
| "Parse a Java version string according to JEP 223 and return the appropriate version." | |||
| [java-ver] | |||
| (try | |||
| (let [[major minor _] (str/split java-ver #"\.") | |||
| (let [[no-opt _] (str/split java-ver #"-") | |||
There was a problem hiding this comment.
I'd probably add some comment here explaining the need for this, as it's exactly obvious.
|
The change seems fine to me. It should also be reflected in the changelog as a bugfix. |
|
I've added those changes. Let me know if you want me to squash commits or anything like that. |
|
What's the status? |
|
My bad. I thought I had already merged this! Thanks for tackling it. Next week I'll cut some new Orchard release, as this week I'm busy around IN/Clojure. |
|
Sounds good. Thank you! Where should I look for a notification of that new release? |
|
I think that if you're watching a repo you get release notifications. I don't usually do public release announcements for bugfix releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See comment here: #57 (comment)
It's currently causing cider to fail for me when I jack in, and the traceback includes orchard failing to get the correct version string.
Changes
letclause ofparse-java-versionNotes
I'm still pretty new to clojure, so if there's a more sane/elegant/appropriate way to lop off the $OPT bit, please let me know.