Ignore non file URLs when checking for directory or file extensions #83
Conversation
|
The proposed change seems reasonable to me. Probably we can make the |
|
How would you make it more compact? |
|
|
||
| (defn file-ext? | ||
| "Whether the argument's path ends in one of the specified case-insensitive | ||
| file extensions" | ||
| [f & exts] | ||
| (let [file (io/as-file f)] | ||
| (when-let [file (if (url? f) | ||
| (when (= (.getProtocol ^java.net.URL f) "file") |
There was a problem hiding this comment.
Here you can combine this condition with the previous using and (for instance). Or you can just replace the condition with one or/and.
There was a problem hiding this comment.
Still something to do here?
| [f] | ||
| (.isDirectory (io/as-file f))) | ||
| (if (url? f) | ||
| (and (= (.getProtocol ^java.net.URL f) "file") |
There was a problem hiding this comment.
Here you can pull this and higher.
There was a problem hiding this comment.
You mean like this ?
(and (url? f)
(= (.getProtocol ^java.net.URL f) "file")
(.isDirectory (io/as-file f)))
Then it would not check nonURLs correctly?
There was a problem hiding this comment.
I was thinking of something like:
(and (url? f) (= (.getProtocol ^java.net.URL f) "file")) ...
With a more complex conditional you can even get rid of the duplicated .isDirectory check, but this will probably make the code hard to read.
There was a problem hiding this comment.
Sorry, but i still do not understand.
You mean like this?
(defn directory?
"Whether the argument is a directory or an url that points to a directory"
[f]
(if (and (url? f) (= (.getProtocol ^java.net.URL f) "file"))
(.isDirectory (io/as-file f))))
There was a problem hiding this comment.
My bad, I just realized where your confusion was coming from. If we structure the condition in this manner, the else branch won't be correct. I should stop reviewing code while doing something else. :D
CHANGELOG.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| * [#83](https://github.com/clojure-emacs/orchard/pull/83): Ignore non file URLs when checking for directory or file extensions | |||
There was a problem hiding this comment.
You should also put "Bugs fixed" above this entry.
There was a problem hiding this comment.
Oh yeah, i see. Sorry
CHANGELOG.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| * [#83](https://github.com/clojure-emacs/orchard/pull/83): Ignore non file URLs when checking for directory or file extensions | |||
There was a problem hiding this comment.
And a . at the end of this sentence. :-)
|
Can you also re-run the failed build? Seems like something unrelated, but still - let's see what happens if we run it a couple of times. |
fp7
force-pushed
the
master
branch
2 times, most recently
from
88fa60f to
1c51b36
Compare
|
Is there a button somewhere that i can click to rerun the tests? |
In a URLClassLoader not all URLs have to be files or directories. Eg. Spring boot's fat jars add entries like "jar:file:..." to the classpath
In a URLClassLoader not all URLs have to be files or directories.
Eg. Spring boot's fat jars add entries like "jar:file:..." to the
classpath