Skip to content

resolve-missing: don't suggest already imported classes #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vemv opened this issue Jul 24, 2023 · 0 comments · Fixed by #403
Closed

resolve-missing: don't suggest already imported classes #402

vemv opened this issue Jul 24, 2023 · 0 comments · Fixed by #403

Comments

@vemv
Copy link
Member

vemv commented Jul 24, 2023

resolve-missing should not suggest e.g. Object since it's already imported by default.

This is best accomplished by inspecting (ns-interns my-ns).

Note that refactor-nrepl.ns.resolve-missing/resolve-missing does not currently accept a ns param (should be optional)

Probably, it's better to add an :already-interned true k-v than to remove the item altogether. That way, we can offer a better UX in clj-refactor.

@vemv vemv closed this as completed in #403 Jul 24, 2023
vemv added a commit that referenced this issue Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant