Fix the build / honor the refresh-dirs
#298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Apr 13, 2021
| (ns global-test-setup | ||
| "This namespace's contents will be automatically loaded by `lein test` (or any test runner)." | ||
| (:require | ||
| [refactor-nrepl.inlined-deps.toolsnamespace.v1v1v0.clojure.tools.namespace.repl :refer [set-refresh-dirs]])) |
There was a problem hiding this comment.
Ideally this would be:
- refactor-nrepl.inlined-deps.toolsnamespace.v1v1v0.clojure.tools.namespace.repl
+ clojure.tools.namespace.replbut I couldn't wait get it to work. It looked like mranderson :expositions would do the trick but nope?
There was a problem hiding this comment.
It seems like this old issue to me benedekfazekas/mranderson#5
| @@ -37,8 +55,28 @@ | |||
| :when ((set deps) ns)] | |||
| file))) | |||
|
|
|||
| (defn- in-refresh-dirs? [refresh-dirs file] | |||
There was a problem hiding this comment.
Can add a unit test to this one. For now I didn't b/c my reasoning was that this is a private helper, and often private helpers are left untested.
Don't know how clojure-emacs folks tend to approach these - would be happy to tweak
There was a problem hiding this comment.
I don't typically add tests for private helpers.
Fixes the build with the following strategy:
* isolate the "Lein plugin" part to its own source path
* this makes it possible to exercise older versions of Clojure, which don't have e.g. `*print-namespace-map*`, which the Lein implementation can assume.
* When tools.namespace `refresh-dirs` are set, don't analyze files outside those refresh dirs.
* This is a quality of life improvement anyway. A properly set up Clojure project (that is using tools.namespace) tends to have the `refresh-dirs` set.
* This way end users don't have extraneous code possibly analyzed code: examples, drafts, production scripts, etc all of which is dangerous to analyze (because analysis == execution).
* For this to work, tools.namespace is resolved in runtime.
* `cider-refresh` does the same: https://git.io/JOYUT
|
The changes look good to me. Thanks! |
This was referenced Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build with the following strategy:
*print-namespace-map*, which the Lein implementation can assume.refresh-dirsare set, don't analyze files outside those refresh dirs.refresh-dirsset.cider-refreshdoes the same: https://git.io/JOYUTlein do clean, test)./build.sh install-- takes a long time)