-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make plugin compatible with Docusaurus beta.13 #88
Conversation
Haha no worries, I assumed importing directly from the lib folder would be fragile and have unannounced breaking changes. I appreciate the PR ❤️ |
This is hard 🤦♂️ Because of facebook/docusaurus#6087 the theme fails to build, but the theme-classic/index file is only used to import a type that we don't use... I tried |
@Josh-Cena Oh, wow thanks for all the work you've put in to this! I think I can fix the typescript issue. I'll checkout your branch and see if I can get it working |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 806d118:
|
Oh hehe, I did add |
No problem :) Thanks for everything you've done, really appreciate it |
Fix #87. See facebook/docusaurus#6047. This change was made in the core to resolve circular dependencies. Sorry for not marking it as breaking change—we aren't expecting anyone to use such implementation detail (at least previously). As now it's found its home in utils, we can assert that it will be stable as long as the architecture isn't completely overhauled.