Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny app deploy when previous deployment's namespace is in terminating state #1322

Closed
devdattakulkarni opened this issue Jul 3, 2024 · 0 comments

Comments

@devdattakulkarni
Copy link
Contributor

The following sequence of events is possible.

An app with the name "app1" is deployed and then deleted. KubePlus is terminating the "app1" Namespace. But before the NS is deleted, "app1" is deployed again. KubePlus will notice that "app1" Namespace exists (it has not terminated yet) and it will try to "upgrade" the app (If NS exists, KubePlus assumes that the app is present and tries to run helm upgrade). But since the NS is terminating, the helm upgrade fails. This failure is not reflected in the app's status message. The outcome is that the app is deployed but there are 0 pods for that app.

We can address this situation by denying the app creation request if a namespace with the app name exists but is in a 'terminating' state.

@devdattakulkarni devdattakulkarni changed the title Deny deploying app with same name when previous is in terminating state Deny app deploy when previous deployment's namespace is in terminating state Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant