Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure] Apply new SDK and fix of getting image list #1275

Merged
merged 13 commits into from
Aug 23, 2024
Merged

[Azure] Apply new SDK and fix of getting image list #1275

merged 13 commits into from
Aug 23, 2024

Conversation

ish-hcc
Copy link
Member

@ish-hcc ish-hcc commented Aug 9, 2024

Azure

Apply new SDK

  • Get rid of deprecated SDK and apply new armXXXXX SDK.
  • Tested for all handlers with CLI and AdminWeb.
  • k8s upgrade is also working.
  • We can now use more functions in SDK.
  • Need to change some directly called APIs to SDK's functions when needed.

Fix of getting image list

  • Only get latest version for same types of images.
  • Previous PR (getting all of version, deprecated SDK): 55693 images, 71 minutes
  • Current PR (getting latest version, new SDK): 19381 images, 50 minutes (about -20 minutes)

@ish-hcc ish-hcc self-assigned this Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Could you please check and revise Korean texts?
Note - All output of print and log statements should be in English. 😉

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Could you please check and revise Korean texts?
Note - All output of print and log statements should be in English. 😉

This was referenced Aug 11, 2024
Closed
Closed
@powerkimhub powerkimhub self-requested a review August 12, 2024 00:20
@powerkimhub
Copy link
Member

@sykim-etri


  • K8S 관련 참고해주시기 바랍니다.
  • Test 진행된 사항이므로 Image 관련된 부분 검토 후에 Merge 예정입니다.
  • @sykim-etri Azure:K8S 관련 기능 점검은 Merge 후에 하시는 것이 좋을 듯합니다.

Azure

Apply new SDK

  • Get rid of deprecated SDK and apply new armXXXXX SDK.
  • Tested for all handlers with CLI and AdminWeb.
  • k8s upgrade is also working.
  • We can now use more functions in SDK.
  • Need to change some directly called APIs to SDK's functions when needed.

@powerkimhub
Copy link
Member

@ish-hcc

@github-actions GitHub Actions
Copy link

Could you please check and revise Korean texts?
Note - All output of print and log statements should be in English. 😉

@github-actions GitHub Actions
Copy link

Could you please check and revise Korean texts?
Note - All output of print and log statements should be in English. 😉

@ish-hcc
Copy link
Member Author

ish-hcc commented Aug 12, 2024

@powerkimhub 업데이트 했습니다. 감사합니다.

@powerkimhub
Copy link
Member

@powerkimhub 업데이트 했습니다. 감사합니다.

@github-actions GitHub Actions
Copy link

Could you please check and revise Korean texts?
Note - All output of print and log statements should be in English. 😉

@ish-hcc
Copy link
Member Author

ish-hcc commented Aug 23, 2024 •
edited
Loading

Last test result: 19450 images / 1857 seconds (About 30 minutes)

@powerkimhub powerkimhub merged commit aa80913 into cloud-barista:master Aug 23, 2024
3 checks passed
@ish-hcc ish-hcc deleted the azure_upgrade branch September 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerkimhub powerkimhub powerkimhub approved these changes

Assignees

@ish-hcc ish-hcc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ish-hcc @powerkimhub