You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed zone control issue for creating VM, K8S and disk attachment.
Azure dose not support zone for subnet and VPC.
Azure only can store tags to VPC.
Store zone information in VPC tags using the subnet name ID and zone
Azure has reserved tag prefixes, azure, microsoft and windows. So, if subnet name ID starts with azure it can't add the tag. So use subnet- prefix when adding the tags.
@powerkimhub
말씀하신 TargetZone이 Disk 쪽에서만 모두 구현되어 있어 유효한 것으로 보입니다
Subnet 쪽에서는 생성, 삭제 시에만 GetZoneLevelCloudConnection() 를 호출 하는 것으로 보입니다
Subnet으로 부터 Zone 정보를 직접적으로 얻기 위해서는 DB에 접근 하는 방법이 유일해 보이는데
CSP Driver단에서 접근하는 것은 로직상 맞지 않는 것 같아 Tag를 이용하여 처리 하는 것으로 구성하였습니다
다른 CSP들에서도 Subnet에서 Zone 정보가 제공되지 않는 경우 같은 문제가 있을것으로 보여집니다.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure
azure
,microsoft
andwindows
. So, if subnet name ID starts withazure
it can't add the tag. So usesubnet-
prefix when adding the tags.