Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rest auth #412

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Add rest auth #412

merged 2 commits into from
Jun 15, 2021

Conversation

jmleefree
Copy link
Member

  • Rest Server 에 Auth 기능 추가
  • rest auth 관련 test script 추가
  • setup.env 에 API_USERNAME, API_PASSWORD 변수 추가

@powerkimhub powerkimhub self-requested a review June 14, 2021 12:26
API_USERNAME := os.Getenv("API_USERNAME")
API_PASSWORD := os.Getenv("API_PASSWORD")

if API_USERNAME != "" || API_PASSWORD != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 현재 if condition은 setup.env 설정이 다음과 같은 경우에도 Auth enable로 들어 갈 수 있는 것 같습니다.

    API_USERNAME=""
    API_PASSWORD="pw"
    

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 API_USERNAME 과 API_PASSWORD 중에 어느 하나라도 값이 설정되어 있으면 Auth enable 로 설정됩니다.
원하는게 API_USERNAME 과 API_PASSWORD 모두 값이 설정되었을 때 Auth enable 로 설정하는건가요?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 넵. 그게 사용자 과실을 막을 수 있겠습니다.

@powerkimhub powerkimhub merged commit 45f46b0 into cloud-barista:master Jun 15, 2021
@jmleefree jmleefree deleted the add-rest-auth branch October 15, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants