Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[+Price, +Region/Zone] Implement IBM's PriceInfoHandler and fix some drivers #991

Merged
merged 7 commits into from
Dec 20, 2023
Merged

[+Price, +Region/Zone] Implement IBM's PriceInfoHandler and fix some drivers #991

merged 7 commits into from
Dec 20, 2023

Conversation

ish-hcc
Copy link
Member

@ish-hcc ish-hcc commented Dec 20, 2023

IBM

  • Implement PriceInfoHandler
  • Call wait.Done() when error occurrs (Fix go routine may not end when error occurred.)

Azure

  • Call wait.Done() when error occurrs (Fix go routine may not end when error occurred.)
  • Fix typo in GetPriceInfo()

OpenStack

  • Fix not available message of PriceInfo
  • Call wait.Done() when error occurrs (Fix go routine may not end when error occurred.)

@powerkimhub powerkimhub self-requested a review December 20, 2023 03:00
@ish-hcc
Copy link
Member Author

ish-hcc commented Dec 20, 2023

Need to speed up IBM's GetPriceInfo() with go routine.

@ish-hcc
Copy link
Member Author

ish-hcc commented Dec 20, 2023 •
edited
Loading

+ IBM: Call wait.Done() when error occurred in PriceInfoHandler

@powerkimhub powerkimhub merged commit c29cf63 into cloud-barista:master Dec 20, 2023
1 check passed
@powerkimhub powerkimhub linked an issue Dec 22, 2023 that may be closed by this pull request
[+Price] IBM-VPC Cloud Driver Implementation #973
Closed
@powerkimhub powerkimhub mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerkimhub powerkimhub powerkimhub approved these changes

Assignees

@powerkimhub powerkimhub

@niconicodex niconicodex

@ish-hcc ish-hcc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[+Price] IBM-VPC Cloud Driver Implementation
3 participants
@ish-hcc @powerkimhub @niconicodex