Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to prepend NS prefix to SG name #1049

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Update to prepend NS prefix to SG name #1049

merged 1 commit into from
Mar 25, 2022

Conversation

jihoon-seo
Copy link
Member

Closes #1044

image
image

@jihoon-seo jihoon-seo requested a review from seokho-son as a code owner March 24, 2022 09:07
seokho-son
seokho-son approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nice enhancement ! :)
LGTM.

@seokho-son seokho-son merged commit fbaa9d8 into cloud-barista:main Mar 25, 2022
@jihoon-seo jihoon-seo deleted the 220324_Fix_SG_NS_prefix branch March 28, 2022 09:50
@jihoon-seo jihoon-seo mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TB does not prepend NS prefix to SG name when calling SP
2 participants
@jihoon-seo @seokho-son