Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NCP-VPC metadata #1125

Merged

Conversation

jihoon-seo
Copy link
Member

@jihoon-seo jihoon-seo commented May 30, 2022

Edit:
현재는 assets/cloudlocation.csv 파일의 ID column에는
소문자로 적어야 매칭이 되는 것으로 보입니다.

이 때문에 이 PR에서는 해당 column의 값을 소문자로 변경하였으며

필요하다면 TB 소스의 매칭 체크 부분에서 ToLower 등을 사용하는 방법도 있겠습니다. 😊

@jihoon-seo jihoon-seo requested a review from seokho-son as a code owner May 30, 2022 06:59
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seokho-son seokho-son merged commit fc03d07 into cloud-barista:main May 30, 2022
@jihoon-seo jihoon-seo deleted the 220530_Update_NCP-VPC_metadata_2 branch May 30, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants