Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updating NS functionality #1132

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Conversation

seokho-son
Copy link
Member

curl -X 'PUT' \
  'http://localhost:1323/tumblebug/ns/ns01' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{
  "description": "user ns",
  "name": "ns01"
}'

Response body
{
"id": "ns01",
"name": "ns01",
"description": "user ns"
}

@seokho-son seokho-son requested a review from jihoon-seo as a code owner June 8, 2022 08:11
@seokho-son
Copy link
Member Author

#1131 와 같이, NS의 info 값이 삭제된 오류를 hot fix 하기 위한 기능 추가 PR 입니다. (@jihoon-seo )

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2022

This pull request introduces 2 alerts when merging 4dac14c into 238be08 - view on LGTM.com

new alerts:

  • 2 for Log entries created from user input

return emptyInfo, err
}

res.Id = id
Copy link
Member

@jihoon-seo jihoon-seo Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NS ID를 변경하는 것은 가능하지 않을 것이므로
이 줄은 없어도 괜찮아 보입니다.
삭제하는 것이 어떨까요? 😊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoon-seo

id 의 값이 "" 로 처리되는 오류가 발생하여, 해당 사항을 수정하기 위한 부분입니다.

NS ID Key 와 내부에 id 항목의 값을 동일하게 만드는 효과가 있어서,

일반적인 상황에서도 문제는 없을 것 같아요.

@jihoon-seo jihoon-seo merged commit 482f3de into cloud-barista:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants