Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NLB mgmt feature #1158

Merged

Conversation

jihoon-seo
Copy link
Member

  • NLB 코드를 mcir 패키지 아래에 뒀더니 mcis 패키지와의 cyclic import 문제가 발생해서
    mcis 패키지 아래에 두었습니다.
  • 이로 인해 MCIR 관련 공통 함수들을 활용할 수 없어서 NLB를 위한 함수들을 새로 정의했습니다.
  • AWS, GCP, Azure, Mock 각각에서 VM 3개에 대해 테스트했습니다.

@jihoon-seo jihoon-seo requested a review from seokho-son as a code owner August 23, 2022 09:12
@seokho-son
Copy link
Member

감사합니다! 연동 개발에서 활용한 스파이더 버전은 어케되나용?^^

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2022

This pull request introduces 25 alerts when merging b9fe2be into 3019903 - view on LGTM.com

new alerts:

  • 24 for Log entries created from user input
  • 1 for Unreachable statement

@jihoon-seo
Copy link
Member Author

네, CB-Spider v0.6.6 + a (9bd9467) 버전을 사용했습니다. 😊
(CB-Spider v0.6.6 태그 이후의 커밋들은
NLB 관련 커밋은 없고
Disk 관련 커밋과 cb-log & cb-store 버전 업데이트 커밋만 있습니다.)

@seokho-son
Copy link
Member

감사합니다!
빠른 개발 진행을 위해서 바로 승인하겠습니다~~

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seokho-son seokho-son merged commit b8b565a into cloud-barista:main Aug 24, 2022
@jihoon-seo jihoon-seo deleted the 220823_Add_NLB_mgmt_feature branch August 24, 2022 09:05
@jihoon-seo jihoon-seo linked an issue Aug 26, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NLB capability to MCIS
2 participants