Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to go 1.19 & Update go.mod #1160

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

jihoon-seo
Copy link
Member

dep 중에서 특히 github.com/mattn/go-sqlite3 의 경우
모든 v2.0.x 버전들은 실수로 찍힌 것이며, 예전 버전이고, retract 되었습니다.
이 PR에서는 이를 v1.14.15 로 업데이트 합니다.

@jihoon-seo jihoon-seo requested a review from seokho-son as a code owner August 25, 2022 09:59
@jihoon-seo jihoon-seo added the hold Need to hold merge label Aug 26, 2022
@jihoon-seo jihoon-seo force-pushed the 220825_Update_go.mod branch from 068e713 to 59e3d4e Compare August 26, 2022 10:47
@jihoon-seo jihoon-seo linked an issue Aug 26, 2022 that may be closed by this pull request
@jihoon-seo
Copy link
Member Author

최초 push에서는 Dockerfile에서 builder 이미지로 golang:1.16-alpine을 사용했었는데,
https://github.com/cloud-barista/cb-tumblebug/runs/8013311555?check_suite_focus=true#step:3:315

# go.uber.org/atomic
/go/pkg/mod/go.uber.org/atomic@v1.10.0/error.go:55:12: x.v.CompareAndSwap undefined (type Value has no field or method CompareAndSwap)
/go/pkg/mod/go.uber.org/atomic@v1.10.0/error.go:61:24: x.v.Swap undefined (type Value has no field or method Swap)
/go/pkg/mod/go.uber.org/atomic@v1.10.0/string.go:58:12: x.v.CompareAndSwap undefined (type Value has no field or method CompareAndSwap)
/go/pkg/mod/go.uber.org/atomic@v1.10.0/string.go:64:12: x.v.Swap undefined (type Value has no field or method Swap)
note: module requires Go 1.18

이러한 에러가 나서
Dockerfile의 builder 이미지를 golang:1.19-alpine 으로 바꾸니
컨테이너 이미지 빌드가 잘 됩니다. 😊

논의해야 할 사항:
README.mdREADME-EN.md 에서 Go 1.16 을 추천하고 있고, Go 설치 방법 예시도 1.16 버전에 대한 것입니다.
이 부분도 업데이트한다면, 이 PR에서 한꺼번에 처리할 수도 있겠습니다.

@seokho-son
Copy link
Member

1.19로 가보시죠! :)
해당 PR에서 한꺼번에 처리하면 좋을 것 같습니다.

@jihoon-seo jihoon-seo force-pushed the 220825_Update_go.mod branch from 59e3d4e to c1efbde Compare August 29, 2022 22:59
@jihoon-seo jihoon-seo changed the title Update go.mod Bump to go 1.19 & Update go.mod Aug 29, 2022
@jihoon-seo
Copy link
Member Author

@seokho-son README 도 수정하였습니다. 😊

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다! :)

@seokho-son seokho-son merged commit be9d9e5 into cloud-barista:main Aug 30, 2022
@jihoon-seo jihoon-seo deleted the 220825_Update_go.mod branch August 31, 2022 02:46
@jihoon-seo jihoon-seo removed the hold Need to hold merge label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New golang release: Go 1.18
2 participants