Add yaml config feature to handle different available values for each cloud #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoon-seo
reviewed
Oct 4, 2022
Comment on lines
+300
to
+315
| // // TODO: update this part to assign availble values for each CSP (current code does not work) | ||
| fmt.Println("NLB available values (AWS): ", common.RuntimeConf.Cloud.Aws) | ||
| fmt.Println("NLB available values (Azure): ", common.RuntimeConf.Cloud.Azure) | ||
| // if cloud-type == aws { | ||
| // tempReq.ReqInfo.HealthChecker.Interval = common.RuntimeConf.Cloud.Aws.Nlb.Interval | ||
| // tempReq.ReqInfo.HealthChecker.Timeout = common.RuntimeConf.Cloud.Aws.Nlb.Timeout | ||
| // tempReq.ReqInfo.HealthChecker.Threshold = common.RuntimeConf.Cloud.Aws.Nlb.Threshold | ||
| // } else if cloud-type == azure { | ||
| // tempReq.ReqInfo.HealthChecker.Interval = common.RuntimeConf.Cloud.Azure.Nlb.Interval | ||
| // tempReq.ReqInfo.HealthChecker.Timeout = common.RuntimeConf.Cloud.Azure.Nlb.Timeout | ||
| // tempReq.ReqInfo.HealthChecker.Threshold = common.RuntimeConf.Cloud.Azure.Nlb.Threshold | ||
| // } else { | ||
| // tempReq.ReqInfo.HealthChecker.Interval = common.RuntimeConf.Cloud.Common.Nlb.Interval | ||
| // tempReq.ReqInfo.HealthChecker.Timeout = common.RuntimeConf.Cloud.Common.Nlb.Timeout | ||
| // tempReq.ReqInfo.HealthChecker.Threshold = common.RuntimeConf.Cloud.Common.Nlb.Threshold | ||
| // } |
There was a problem hiding this comment.
이 코드가 작동해야 할 것 같은데 왜 안되는걸까요.. ㅎㅎ 🤔
[예상 로직]
- 사용자가 "Create NLB" REST API 호출 시에 interval, timeout, threshold 전부/일부를 명시했다면
→ 해당 값을 사용 - 사용자가 "Create NLB" REST API 호출 시에 명시하지 않은 interval, timeout, threshold 에 대해서는
YAML에 있는 (기본)값을 사용
이렇게 하면 좋을까요? 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yaml config 파일의 로드 및 갱신은
https://github.com/spf13/viper (MIT 라이선스) 를 활용하였으며, 이는 cobra 등에서 많이 활용되는 오픈소스이므로, 신뢰할 수 있음.
main에서 로드된 yaml 파일의 정보는
cb-tumblebug/src/core/common pkg에서 전역 변수에 바인딩하여, 전역에서 사용할 수 있도록 되어 있음.
NLB 코드에 적용 필요.