Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set NLB health checker info by reflection #1196

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

yunkon-kim
Copy link
Member

  • Via 'reflect', get a cloud setting object from the conditional and hierarchical object structure
  • Set NLB health checker info
  • Remove conditional switch-case

reflect package를 활용해 NLB health checker info를 설정하는 PR 입니다. (기존 Switch-case문을 대체)

관련 부분만 집중 수정하였고, 용어 및 내용을 정확하게 하고 진행한 것이 아니라서 Draft PR로 오픈하였습니다 ^^;;

검토해 보시고 의견을 남겨주시기 바랍니다.

- Via 'reflect', get a cloud setting object from the conditional and hierarchical object structure
- Set NLB health checker info
- Remove conditional switch-case
Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넘 좋네요.. 감사합니다 ㅎㅎㅎ

@seokho-son seokho-son marked this pull request as ready for review October 13, 2022 09:33
@seokho-son seokho-son self-requested a review as a code owner October 13, 2022 09:33
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, we can remove the comments.

src/core/mcis/nlb.go Outdated Show resolved Hide resolved
@seokho-son
Copy link
Member

@yunkon-kim 감사합니다!! :)

제가 내려받아서, 정상 동작 여부까지 확인하였습니다. (잘 동작합니다!)
참고로 해당 개선을 확인하기 위해서는
mcis 생성 후, 특정 vmGroup을 대상으로 NLB 를 생성해보면 됩니다. :)

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seokho-son seokho-son merged commit d26a642 into cloud-barista:main Oct 13, 2022
@yunkon-kim yunkon-kim deleted the simplify-nlb-option-setup branch January 10, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants