Change func name CorePostMcisVm into CreateMcisVm
#1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed function name from CorePostMcisVm to CreateMcisVm
|
Hi @Rohit-R2000 You need to search the text of the legacy func name in all files in src/*. and change the text too. :) Please update your PR :) |
|
This pull request fixes 2 alerts when merging ba45c4c into 957273f - view on LGTM.com fixed alerts:
|
|
ref #1217 |
seokho-son
changed the title
CorePostMcisVm into CreateMcisVm
|
Ping @Rohit-R2000 :) |
|
Hi @Rohit-R2000 |
|
This pull request fixes 2 alerts when merging ec2bf47 into 08a2606 - view on LGTM.com fixed alerts:
|
|
I updated this PR myself as the maintainer to resolve build failure. Thank @Rohit-R2000 |
seokho-son
approved these changes
Nov 1, 2022
|
@all-contributors please add @Rohit-R2000 for code |
|
I've put up a pull request to add @Rohit-R2000! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed function name from CorePostMcisVm to CreateMcisVm