Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide show or hide option for sshKey in access info #1222

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

seokho-son
Copy link
Member

(기본) 프라이빗 키 항목 삭제

{
  "McisId": "mcis01",
  "McisSubGroupAccessInfo": [
    {
      "SubGroupId": "g1",
      "McisVmAccessInfo": [
        {
          "vmId": "g1-1",
          "publicIP": "13.125.209.56",
          "privateIP": "192.168.20.133",
          "sshPort": "22"
        },
        {
          "vmId": "g1-2",
          "publicIP": "43.201.72.240",
          "privateIP": "192.168.20.172",
          "sshPort": "22"
        }
      ]
    },
    {
      "SubGroupId": "g2",

(accessInfoOption=showSshKey 요청시) 프라이빗 키 제공

{
  "McisId": "mcis01",
  "McisSubGroupAccessInfo": [
    {
      "SubGroupId": "g1",
      "McisVmAccessInfo": [
        {
          "vmId": "g1-1",
          "publicIP": "13.125.209.56",
          "privateIP": "192.168.20.133",
          "sshPort": "22",
          "privateKey": "-----BEGIN RSA PRIVATE KEY-----\nMIIEowIBAAKCAQEAz21/aE1qLfUlBTT0dSZpOkKYGvnIIcj2U07CyDckTcWKj7Ua\nkJL+5m9GtWQOBGAiN2z+nsjaYT3Bf81i2XFsKB2xWXYNpbOVvbyMNJyiRZpxLGeE\nyJOMXDaOBvxWC+X+j6fKEfcRCkxaU4K00Pe2XpLa1I5nKpvkWD20PBc6bxNWBVyP\nCU9hLF9TEBhOYZhoqMI/eb7B4J27RINZ91KjaOXBYTLghI3YkPQgXbFEk+PuM6xo\nG8ceUZi4rmiH5UoLPB+1zC7doAt2dgLd2kIHFH55wtfINaW+ArakKbx8fGVj0RfZ\nutBWU2ItH25TBTXAA+lK8lwB6WkYWSukkA1JdQIDAQABAoIBAAGOpOI3kpB9wqVj\nXGJ0w114moO5VFNMmuzNLpEqOM+MqBmkFmr3b4pzU2iRM7m8rwUTgGXYxCrut8Ep\n3ZAcVd+HOYmeZUPVMU6XV8YdVuqG2kqnDEwlL2yRzEcpJcw5EcwqSk4QOMSHBjaS\nSKE4+tmC6LmnyAZ93Rz8eZnp4rpqu0QBsnUmQCdfsMGV45rQGkjYG1mddHYchrxf\nwPDUu50yEKS/BU25yE63Dr/+XePOec3ed4xeuzXLJ4WTls+owF68WO1uTxLvMQoe\nNHlTgT6L56mWxoGWAraubPTW5COH+tlgafjqkkYrqd8ozxKAg3nVsR39H5cvhGQl\nJWpIZgECgYEA/9D2f6djgUbY5z2+k07Bs+CSIWDDnrzaFrEJdo5BXe1GnTHoC5hG\ncz5LvFgD1KCf+LdQ3PxrtehP60EbaEgA2di4ZZTMcLiIyGXH4iYstCm/WXdUaKg0\nqSyYuckuXIqDqXs/i5PPz0+1IDnGpNlC5Oj0mgx48OGi1J7hj+YRnFUCgYEAz5Oj\nN4cELA87bT0zpeUzyy8COlcATP3JcigI0F/fFrDcn5mdBGeNGiMeQzcMMnYyeG2l\nu5j3uU8UFeRl5bqm1hPw2rz8LdGExluM4vjG+m9aEwekn+KBk2+KVOfrRjqqYCIy\nI9WMZVPWp4aaCAazYz/PxeCO/iNLsCGN86kKGKECgYBW9au1fStAGNtG0CBmZtFF\n2kMSgZg976ibKhcza+wgh7YHXZ2pw1u/dR+9qJW0w91daMNeO5hJv+za5cjxS/iu\nFROpxEky0Cf/J0opQBzWKZLYUM4qvXMZRwWrsg3Ge3eCN1lEkzyDFm9Vww4Zn5kz\nw1TSwQajq6/0YwX+KpE1+QKBgC6RsclwWghEdpGg

Comment on lines 45 to 47
// @Param filterKey query string false "(For option==id) Field key for filtering (ex: connectionName)"
// @Param filterVal query string false "(For option==id) Field value for filtering (ex: aws-ap-northeast-2)"
// @Param accessInfoOption query string false "(For option==accessinfo) accessInfoOption (showSshKey)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST API 호출 시
http://.../ns/{nsId}/mcis/{mcisId}?option=id 와 같이 사용하고 있어서
아래와 같이 제안합니다.. ㅎㅎ
(option== 으로 찾아 보면 다른 곳에 3곳 더 있습니다)

Suggested change
// @Param filterKey query string false "(For option==id) Field key for filtering (ex: connectionName)"
// @Param filterVal query string false "(For option==id) Field value for filtering (ex: aws-ap-northeast-2)"
// @Param accessInfoOption query string false "(For option==accessinfo) accessInfoOption (showSshKey)"
// @Param filterKey query string false "(For option=id) Field key for filtering (ex: connectionName)"
// @Param filterVal query string false "(For option=id) Field value for filtering (ex: aws-ap-northeast-2)"
// @Param accessInfoOption query string false "(For option=accessinfo) accessInfoOption (showSshKey)"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoon-seo 바로 적용하였습니다!

Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
@jihoon-seo jihoon-seo merged commit bd7cb32 into cloud-barista:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants