Fix bugs on NLB mgmt feature #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloud_conf.yaml파일에서 각 CSP별 interval, timeout, threshold 값을 읽어 적용하는 기능cb-tumblebug/src/core/common/config.go파일의Cloudstruct에 정의해 놓지 않은 CSP (예:NCPVPC) 에 대해서는cloud_conf.yaml파일에 값을 기재하더라도src/core/mcis/nlb.go파일의 L382 에서 panic error 가 발생함cb-tumblebug/src/core/common/config.go파일의Cloudstruct에 정의해 놓지 않아(L382 →) L394 에서 panic error 가 발생하면
cloud_conf.yaml파일의common필드에 기재되어 있는 값을 사용하도록 함 (L390)tempSpiderNLBHealthInfo.Healthinfo.HealthyVMs또는tempSpiderNLBHealthInfo.Healthinfo.UnHealthyVMs가 nil 이면기존 L1175 또는 L1184 에서 nil (null? 😅) pointer error 발생
tempSpiderNLBHealthInfo.Healthinfo.HealthyVMs및tempSpiderNLBHealthInfo.Healthinfo.UnHealthyVMs가 nil 이 아닐 때에만그 값을 읽도록 함
[오늘자 테스트 현황]