Hotfix for runtime err in monitoring agent #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoon-seo
reviewed
Nov 8, 2022
| @@ -265,7 +265,6 @@ func CallMonitoringAsync(wg *sync.WaitGroup, nsID string, mcisID string, mcisSer | |||
|
|
|||
| result = string(body) | |||
| } | |||
| defer res.Body.Close() | |||
There was a problem hiding this comment.
L264 에서 이미 defer res.Body.Close() 를 했는데, 여기서 또 수행하려니 런타임 에러가 났던걸까요.. ㅎㅎ
There was a problem hiding this comment.
L264 에서 이미
defer res.Body.Close()를 했는데, 여기서 또 수행하려니 런타임 에러가 났던걸까요.. ㅎㅎ
@jihoon-seo
api호출 오류(cb-df로 호츌이 타임아웃을 내뿜을 때)가 발생했을 때
res 가 nil 인데 close 하려고 해서 발생하는 닐포인터 애러입니당! :)
이미 nil인 경우를 대비해서 close를 하고 있어서. 삭제만 하였습니다. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.