-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cb-store with etcd #1695
Conversation
* Add `setup-auth.sh` and `.env`, which is used by Docker Compose * Set up or apply auth on etcd server through `etcd-setup-auth` (an ephemeral container) * Improve configuration for connecting to `etcd` and `kvstore` - Add environment variables of `etcd` - Read envs and set to the configs (including auth info) - Retry several times until you connect to the `etcd` server * Update examples for `etcd` test
* Add `.env` and set variables with interpolation in the compose file * Specify environment variables for Docker-Compose * Match the specified environment variables with the environment variables of each service * Set default values for each service environment variable
* Add `setup-auth.sh` and `.env`, which is used by Docker Compose * Set up or apply auth on etcd server through `etcd-setup-auth` (an ephemeral container) * Improve configuration for connecting to `etcd` and `kvstore` - Add environment variables of `etcd` - Read envs and set to the configs (including auth info) - Retry several times until you connect to the `etcd` server * Update examples for `etcd` test
* Add `.env` and set variables with interpolation in the compose file * Specify environment variables for Docker-Compose * Match the specified environment variables with the environment variables of each service * Set default values for each service environment variable
* Add environment variables of etcd to `setup.env`, `Dockerfile`, `docker-compose.yaml`, and `docker-compose-custom.yaml` * Specify `pull_policy: missing` for cb-tumblebug service in `docker-compose.yaml` and `docker-compose-custom.yaml` * Read `etcd` environment variables and initialize `kvstore` * Note - the endpoints environment variable of TB in `.env` specifies the target, because setting the environment variable can affect the relationship between compose services.
scripts/cleanDB.sh https://github.com/cloud-barista/cb-tumblebug/blob/main/scripts/cleanDB.sh#L13 도 기존대로 동작하려나요? 아님, container-volume 전체를 삭제하는게 바람직하려나요. |
etcd의 경우 volume을 다음과 같이 설정해 둔 상황으로 기존대로 동작하지 않을 것으로 보입니다. volumes:
- ./container-volume/etcd/data:/etcd-data 확인해보니 별도의 etcd 데이터 삭제 구문을 추가하도록 하겠습니다. |
cb-tumblebug/scripts/cleanDB.sh Line 13 in 28d86a7
cb-tumblebug/scripts/runContainer.sh Line 19 in 28d86a7
어떻게 처리하면 좋을지 문의드립니다. (cleanDB.sh 실행 시 둘 다 삭제?) |
넵, 둘 다 삭제하는 것이 바람직해보입니다. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/approve |
This PR will replace
cb-strelog
withkvstore
based onetcd
.kvstore
,kvutil
,etcd
pkgs will be added.docker compose
will runetcd
server and configure a basic level auth toetcd
.docker compose
.Please see below for further details.
kvstore
pkg and improve functionality #1686