Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance env variables #1698

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Enhance env variables #1698

merged 3 commits into from
Jul 31, 2024

Conversation

seokho-son
Copy link
Member

  • remove redundant ENV variables
  • Add TB_ prefix for all ENV variables (to differentiate ENV vars defined in the related systems)

@seokho-son seokho-son requested a review from yunkon-kim as a code owner July 31, 2024 06:15
@github-actions github-actions bot added docs Improvements or additions to documentation src script labels Jul 31, 2024
@seokho-son
Copy link
Member Author

PTAL @yunkon-kim

tested by docker compose up --build

@seokho-son
Copy link
Member Author

/approve

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label Jul 31, 2024
@cb-github-robot cb-github-robot merged commit 7f48537 into cloud-barista:main Jul 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@yunkon-kim yunkon-kim Awaiting requested review from yunkon-kim yunkon-kim is a code owner

Assignees
No one assigned
Labels
approved This PR is approved and will be merged soon. docs Improvements or additions to documentation script src
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seokho-son @cb-github-robot