Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance logger pkg #1709

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Enhance logger pkg #1709

merged 1 commit into from
Aug 13, 2024

Conversation

yunkon-kim
Copy link
Member

  • Set permission to read log file in container volume
  • Set relative path with line number by zerolog.CallerMarshalFunc
    • This will make it easy to access the lines in the file that were logged in the IDE.
    • I expect this will ensure that the log format remains consistent across different execution environments.

@yunkon-kim
Enhance logger pkg
e260786 
* Set permission to read log file in container volume
* Set relative path with line number by zerolog.CallerMarshalFunc
  - This will make it easy to access the lines in the file that were logged in the IDE.
  - I expect this will ensure that the log format remains consistent across different execution environments.
@yunkon-kim yunkon-kim requested a review from seokho-son as a code owner August 13, 2024 04:27
@github-actions github-actions bot added the src label Aug 13, 2024
@yunkon-kim
Copy link
Member Author

/approve

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label Aug 13, 2024
@cb-github-robot cb-github-robot merged commit 3b4f7db into cloud-barista:main Aug 13, 2024
4 checks passed
@yunkon-kim yunkon-kim deleted the 240813-11 branch September 2, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

Assignees
No one assigned
Labels
approved This PR is approved and will be merged soon. src
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunkon-kim @cb-github-robot