Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker/setup-buildx-action from 1.5.1 to 1.6.0 #710

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 6, 2021

Bumps docker/setup-buildx-action from 1.5.1 to 1.6.0.

Release notes

Sourced from docker/setup-buildx-action's releases.

v1.6.0

  • Add config-inline input (#106)
  • Bump @​actions/core from 1.4.0 to 1.5.0 (#104)
  • Bump codecov/codecov-action from 1 to 2 (#101)
Commits
  • 94ab11c Merge pull request #106 from crazy-max/config-inline
  • 34e94a5 Add config-inline input
  • ee7ac31 Merge pull request #104 from docker/dependabot/npm_and_yarn/actions/core-1.5.0
  • 93fe949 Update generated content
  • 75abbe0 Bump @​actions/core from 1.4.0 to 1.5.0
  • e639814 Merge pull request #101 from docker/dependabot/github_actions/codecov/codecov...
  • 96016fa Use major
  • cddc648 Merge pull request #102 from crazy-max/update-deps
  • 1e85bf3 Use official images
  • 7c99741 Bump codecov/codecov-action from 1 to 2.0.1
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1.5.1 to 1.6.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v1.5.1...v1.6.0)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 6, 2021
@jihoon-seo
Copy link
Member

/lgtm
(Testing the merged PR #709 again)

@github-actions github-actions bot added the lgtm This PR is acceptable by at least one reviewer label Sep 6, 2021
@jihoon-seo
Copy link
Member

/approve

@jihoon-seo
Copy link
Member

훔.. 지금은 GitHub workflow를 이용한 auto merge 는 안 되네요..

예전 PR #398 을 보면
/approve comment가 달리면
github-actions 봇이 "approved" 레이블을 달고
github-actions 봇이 merge를 수행합니다.
(github-actions 봇이 merge를 수행하는 조건: "lgtm" 레이블 + "approved" 레이블 로 추정됨)

이 PR을 보면
github-actions 봇이 approve를 하기는 했는데
"approved" 레이블을 달지는 않았습니다.

그런데 또, PR #709 를 보면, "lgtm" 레이블만 있고 "approved" 레이블은 없고
seokho-son 님께서 merge를 수행했다고 나옵니다.
(GitHub UI에서 "Enable auto-merge" 를 하신걸까요..)

훔.. 🤔

[FYI]

@seokho-son
Copy link
Member

@jihoon-seo 오토머지 워크플로(approve 및 머지 조건 확인시 자동 머지)는 꺼두었어요. 몇가지 이슈(머비 장법 지정이 어려움. 권한 이슈 등등)가 있는듯하여~~ 향후에 깃허브 빌트인 기능이 만들어지면 대체할까 했습니다.

레이블 워크플로우는 작동하는데 (label, approve 등)
여기서 approve 는 레이블을 달아주고, 리뷰 완료 처리를 해주기 때문에 메인테이나가 PR 을 머지할 슈 있는 버튼을 활성화해줍니다.

@seokho-son seokho-son merged commit d756c0f into main Sep 6, 2021
@seokho-son seokho-son deleted the dependabot/github_actions/docker/setup-buildx-action-1.6.0 branch September 6, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR is acceptable by at least one reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants