Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#655] [Enhancement/655] Task 1 and Task 2 #758

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

ChobobDev
Copy link
Member

This PR consist following tasks
이 PR은 다음 task들에 대한 PR입니다.

  • cb-tumblebug/i18n 디렉토리 생성 및 README-EN.md 파일 생성
  • cb-tumblebug/README.md 를 수정하여, README-EN.md 링크 제공 (WIP를 표시)

Had problems with PR due to some commits from different branch was applied to this PR so it took some time.
PR중 commit이 꼬여서 다시 작업해서 PR 올립니다

Thank you
감사합니다.

@seokho-son
Copy link
Member

/lgtm

@github-actions github-actions bot added the lgtm This PR is acceptable by at least one reviewer label Sep 23, 2021
@seokho-son
Copy link
Member

/approve

@seokho-son
Copy link
Member

감사합니다!! :)

@seokho-son seokho-son merged commit c639a66 into cloud-barista:main Sep 23, 2021
@seokho-son
Copy link
Member

@all-contributors please add @ChobobDev for Documentation

@allcontributors
Copy link
Contributor

@seokho-son

I've put up a pull request to add @ChobobDev! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR is acceptable by at least one reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants