Move MCIS refine feature's REST API: from GET /mcis to GET /control/mcis #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @PARKINHYO |
jihoon-seo
reviewed
Sep 23, 2021
| @@ -342,7 +342,7 @@ func RestGetControlMcis(c echo.Context) error { | |||
|
|
|||
| action := c.QueryParam("action") | |||
|
|
|||
| if action == "suspend" || action == "resume" || action == "reboot" || action == "terminate" { | |||
| if action == "suspend" || action == "resume" || action == "reboot" || action == "terminate" || action == "refine" { | |||
There was a problem hiding this comment.
지금 드는 생각은..
개인적으로는
이 경우처럼 case 가 많은 경우에는
switch-case + fallthrough 로 짜는 것이 더 좋은 것 같기는 합니다.. 😊
There was a problem hiding this comment.
맞습니다 ㅎㅎ 코드 수정할 때는 생각 못했었는데 지금 다시 보니깐 switch문으로 바꾸는게 좀 더 코드가 이쁠 것 같네요😊
시간될 때 한번 고쳐보겠습니다.
|
@PARKINHYO 깔끔하게 잘 처리해주셨네요!! 기여 감사합니다~~ ^^ |
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #755
RestGetMcis(c echo.Context) error함수의action == "refine"조건 삭제 및RestGetControlMcis(c echo.Context) error함수에action == "refine"조건 추가