Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #799

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Update README.md #799

merged 1 commit into from
Sep 27, 2021

Conversation

Jayita10
Copy link
Contributor

Fixed issue #796

@seokho-son
Copy link
Member

Thank you @Jayita10. Looks good to me !!

CB-Tumblebug welcomes improvements from all contributors, new and experienced!
We look forward to further contributions from you~! :)

@seokho-son
Copy link
Member

/lgtm

@seokho-son
Copy link
Member

/approve

@github-actions github-actions bot added the lgtm This PR is acceptable by at least one reviewer label Sep 27, 2021
@seokho-son seokho-son merged commit bee437f into cloud-barista:main Sep 27, 2021
@seokho-son
Copy link
Member

@all-contributors please add @Jayita10 documentation

@allcontributors allcontributors bot mentioned this pull request Sep 27, 2021
Merged
@allcontributors
Copy link
Contributor

@seokho-son

I've put up a pull request to add @Jayita10! 🎉

@jihoon-seo jihoon-seo linked an issue Sep 27, 2021 that may be closed by this pull request
Error in docker run ... command #796
Closed
@Jayita10
Copy link
Contributor Author

Jayita10 commented Sep 27, 2021 •
edited
Loading

Thank you @Jayita10. Looks good to me !!

CB-Tumblebug welcomes improvements from all contributors, new and experienced!
We look forward to further contributions from you~! :)

Thank you @seokho-son :)
Just a suggestion, I think the same should be changed here also.

@seokho-son
Copy link
Member

@Jayita10 Thank you for the suggestion !!

https://github.com/cloud-barista/cb-tumblebug/blob/main/i18n/README-EN.md is a Readme in English. However, WIP.

Whereas the document is WIP, I think we can keep sync as you suggested !

Cloud you contribute to this issue too? :)

@Jayita10
Copy link
Contributor Author

@Jayita10 Thank you for the suggestion !!

https://github.com/cloud-barista/cb-tumblebug/blob/main/i18n/README-EN.md is a Readme in English. However, WIP.

Whereas the document is WIP, I think we can keep sync as you suggested !

Cloud you contribute to this issue too? :)

Would love to do 😊, though you can make this first-timers-only issue so that new people can contribute 😃

@seokho-son seokho-son mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

Assignees
No one assigned
Labels
lgtm This PR is acceptable by at least one reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in docker run ... command
2 participants
@Jayita10 @seokho-son