Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#655] Completion of README.md Translation #825

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

ChobobDev
Copy link
Member

I have managed to translate README.md

Please leave comment if there are any typos or misleading information of the translation.

Thank you

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChobobDev Thank you for the huge efforts to globalization of this project !!
In general, LGTM.
I found some typos, please fix typos :)

  • Inatall - Install (or Installation)
  • Environmentla - Environmental
  • cnofiguring - configuring
  • Trubleshooting - Troubleshooting
  • reslove - resolve

I think we need to sync English readme with the Korean readme.
I will invite contributors !

Again thank you very much ! 👍

@@ -109,7 +109,7 @@ CB-Tumblebug welcomes improvements from all contributors, new and experienced!

### (1) Source Code based Installation and Execution

- 개요
- Table of Contents
- Inatall tools and packages required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some Typos
Inatall -> Install or Installation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reviews,

I did not realize there were so many typos

I Will work on it ASAP

Thank you Again

@ChobobDev
Copy link
Member Author

ChobobDev commented Oct 6, 2021

I have used VS Code Extensions to review my commit so I believe there are no more Typos on this document.

Again, Thank you for your hard work in finding my typos on this markdown file.

Thank you

@seokho-son
Copy link
Member

/lgtm

@github-actions github-actions bot added the lgtm This PR is acceptable by at least one reviewer label Oct 6, 2021
@seokho-son
Copy link
Member

/approve

@seokho-son
Copy link
Member

@ChobobDev Thank you~~!!

@seokho-son seokho-son merged commit 2eb6b38 into cloud-barista:main Oct 6, 2021
@seokho-son seokho-son added the hacktoberfest-accepted hacktoberfest-accepted label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest-accepted lgtm This PR is acceptable by at least one reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants