Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBTUMBLEBUG_ROOT by project directory for container #862

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

seokho-son
Copy link
Member

Similar to #818

I applied it to the script to run containers.

CBTUMBLEBUG_ROOT is used to locate container volume.

@seokho-son
Copy link
Member Author

@hermitkim1 I think you can review this PR. :)

@yunkon-kim
Copy link
Member

@seokho-son I have one thing to check from you ^^

I think scripts in cb-tumblebug/scripts/ have a special purpose.

Thus, you want to set CBTUMBLEBUG_ROOT in a cloned directory.

For a while, I thought that the source code path should not be affected when running containers.

The two cases are different, right?

@seokho-son
Copy link
Member Author

seokho-son commented Oct 13, 2021

@hermitkim1

I think scripts in cb-tumblebug/scripts/ have a special purpose.

Thus, you want to set CBTUMBLEBUG_ROOT in a cloned directory.

Yes ! very special

For a while, I thought that the source code path should not be affected when running containers.

The two cases are different, right?

source code path should not be affected when running containers right !
This script does not pass the CBTUMBLEBUG_ROOT to container ENV.

@seokho-son seokho-son force-pushed the main branch 2 times, most recently from c106728 to 7f9e72b Compare October 13, 2021 22:07
@yunkon-kim
Copy link
Member

/lgtm

@github-actions github-actions bot added the lgtm This PR is acceptable by at least one reviewer label Oct 14, 2021
@seokho-son
Copy link
Member Author

@jihoon-seo PTAL :)

@jihoon-seo
Copy link
Member

LGTMT 입니다 😊

@jihoon-seo jihoon-seo merged commit 8b68a82 into cloud-barista:main Oct 14, 2021
@jihoon-seo jihoon-seo added the hacktoberfest-accepted hacktoberfest-accepted label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest-accepted lgtm This PR is acceptable by at least one reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants