Replace beego validation with go-playground/validator #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokho-son
reviewed
Oct 22, 2021
| } | ||
| } | ||
| return nil | ||
| */ |
There was a problem hiding this comment.
@jihoon-seo
legacy code 에 특별한 의미(향후 재활용 가능성, 참고 필요 등)가 남아 있지 않다면, 주석 처리보다는 삭제가 어떨까요?
There was a problem hiding this comment.
@seokho-son 리뷰 감사합니다.
의견 주신 대로, 주석 처리 하지 않고 삭제하였습니다 😊
jihoon-seo
force-pushed
the
211022_Replace_beego_validation_with_go-playground/validator
branch
from
d0d5a84 to
edf75e8
Compare
jihoon-seo
force-pushed
the
211022_Replace_beego_validation_with_go-playground/validator
branch
from
edf75e8 to
d7c3e19
Compare
|
Resolved merge conflict. 😊 |
|
/lgtm |
seokho-son
approved these changes
Oct 25, 2021
jihoon-seo
deleted the
211022_Replace_beego_validation_with_go-playground/validator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-playground/validator#754