-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang-jwt/jwt/v4 version #904
Conversation
Hello @BamButz ~! Thank you for the contribution. Welcome to CB-Tumblebug project :) You are right. The guide in the issue #898 is not appropriate :) The problem ( Other external packages that CB-Tumblebug utilize include son@son:~/go/src/github.com/cloud-barista/cb-tumblebug$ go mod graph | grep github.com/dgrijalva/jwt-go github.com/labstack/echo/v4@v4.2.1 github.com/dgrijalva/jwt-go@v3.2.0+incompatible We need to use updated version for those packages to fully resolve #898 Anyway! This PR is acceptable and meaningful (fully up-to-date version). |
/lgtm |
@all-contributors please add @BamButz for code |
I've put up a pull request to add @BamButz! 🎉 |
@BamButz I added you in contributor list of CB-Tumblebug project :) |
Also, please fill free to open a issue regarding the package security issue. |
PR regarding #898
The subject of #898 seems to be already accomplished.
In this PR, I've upgraded
github.com/golang-jwt/jwt/v4
to version4.1.0
to be fully up-to-date on this.closes #898