Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KTcloud info #913

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

jihoon-seo
Copy link
Member

  • Add KTcloud info
    • image, spec 정보가 아직 없으며, 테스트가 수행되지 않았습니다. 추후 보완 및 테스트가 필요합니다.
  • Resolves Tidy testclient/scripts/conf.env #885

@@ -47,7 +48,7 @@ RegionKey02[$IX,$IY]=Zone
RegionVal02[$IX,$IY]=ap-southeast-1a
CONN_CONFIG[$IX,$IY]=aws-ap-se-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main에 수정되어 있는 내용이 반영이 안되어 있는데
conflict가 나지는 않네요? 혹시 미리 rebase가 필요할까요?

Suggested change
CONN_CONFIG[$IX,$IY]=aws-ap-se-1
CONN_CONFIG[$IX,$IY]=aws-ap-southeast-1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 로컬 환경에서 rebase 후 검색해 보니
aws-ap-se-1 는 사라졌고
aws-ap-southeast-1 로 변경되어 있습니다.

머지된 #915 의 영향으로 보입니다. 😊

제 로컬 환경에서 rebase 한 것을 force-push 하겠습니다. 😊

@jihoon-seo jihoon-seo force-pushed the 211102_Add_KTcloud_info branch from 03d0c78 to 86637ab Compare November 3, 2021 01:03
@seokho-son
Copy link
Member

/approve

감사합니다!! :)

@seokho-son seokho-son merged commit a3a993a into cloud-barista:main Nov 3, 2021
@jihoon-seo jihoon-seo deleted the 211102_Add_KTcloud_info branch November 3, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidy testclient/scripts/conf.env
2 participants