Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IBM-VPC #939

Merged

Conversation

jihoon-seo
Copy link
Member

VM 생성 및 삭제까지 되는 것을 확인했습니다.

다만, VM terminate가 다른 CSP에 비해 오래 걸려서 (2~3분)
clean-all.sh 스크립트로 테스트 시
SSH key, SG, vNet 삭제에 실패합니다. (resources in use)

[Related]

@jihoon-seo jihoon-seo requested a review from seokho-son November 5, 2021 06:57
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoon-seo 간략히 리뷰해보았습니다.
테스트는 어떻게 진행하신 것인지요? 등록된 리전들을 모두 포함하는 테스트이려나요?

.gitignore Show resolved Hide resolved
assets/cloudlocation.csv Show resolved Hide resolved



## IBM-VPC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IBM-VPC 드라이버도 있고, IBM-?? 드라이버도 있는 상황이려나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IBM Cloud 에는 'Classic Infrastructure' 와 'VPC Infrastructure' 가 있고,
CB-Spider에서는 둘 중 'VPC Infrastructure' 를 지원하기로 결정하셨습니다.

현재는 (CB-Spider 등에서) IBM = IBM-VPC 를 지칭하며
추후 'Classic Infrastructure' 드라이버가 추가로 개발될 가능성은 낮아 보입니다.

'IBM-VPC' 등으로 명시하면
사용자가 봤을 때 CB가 IBM Cloud 의 두 가지 환경 중 'VPC Infrastructure' 를 지원하고 있다는 것을
명시적으로 알려줄 수 있지 않을까 합니다.. 😊

src/testclient/scripts/testSet.env Show resolved Hide resolved
src/testclient/scripts/testSet.env Outdated Show resolved Hide resolved
@jihoon-seo jihoon-seo force-pushed the 211105_Add_support_for_IBM-VPC branch from a6aa12c to 6c4afaa Compare November 8, 2021 02:29
@jihoon-seo
Copy link
Member Author

@seokho-son

테스트는 어떻게 진행하신 것인지요? 등록된 리전들을 모두 포함하는 테스트이려나요?

cb-tumblebug/src/testclient/scripts/ 에 있는 스크립트로 테스트를 수행했으며
us-south (Dallas (US South)) 리전의 us-south-1 존에 대해 테스트를 해 보았습니다.. 😊

@jihoon-seo jihoon-seo added the hold Need to hold merge label Nov 8, 2021
@jihoon-seo jihoon-seo force-pushed the 211105_Add_support_for_IBM-VPC branch from 6c4afaa to a5bba35 Compare November 8, 2021 07:09
@jihoon-seo jihoon-seo removed the hold Need to hold merge label Nov 8, 2021
@jihoon-seo
Copy link
Member Author

jihoon-seo commented Nov 8, 2021

  • force-push: Zone별 ubuntu 18.04 image의 SystemID를 반영했습니다.

From @innodreamer :

IBM VPC cloud 연동 driver에 대한 CB-Spider 통합 테스트를 완료했습니다.
각 zone별 테스트 내용은 첨부 파일을 참고하시기 바랍니다.

[IBM VPC 연동 driver test (CB-Spider API 이용)-211105.xlsx]

IBM VPC cloud에서 zone별로 ubuntu 18.04 image의 SystemID가 다르니 TB기준 설정 파일들을 작성하실 때 아래의 내용을 참고하시기 바랍니다.

export CONN_CONFIG=ibmvpc-us-east-1-config
export IMAGE_NAME=r014-dc446598-a1b5-41c3-a1d6-add3afaf264e

# export CONN_CONFIG=ibmvpc-jp-tok-1-config
# export IMAGE_NAME=r022-61fdadec-6b03-4bd2-bfca-62cd16f5673f

# export CONN_CONFIG=ibmvpc-jp-osa-1-config
# export IMAGE_NAME=r034-522c639c-52e1-4cab-8dfb-bc0fb9f6f577

# export CONN_CONFIG=ibmvpc-eu-gb-1-config
# export IMAGE_NAME=r018-1d7417c6-893e-49d4-b14d-9643d6b29812

# export CONN_CONFIG=ibmvpc-eu-de-1-config
# export IMAGE_NAME=r010-1f68eb2d-f35c-4959-8f4b-2b2f9cf78102

# export CONN_CONFIG=ibmvpc-ca-tor-1-config
# export IMAGE_NAME=r038-e92647cf-8be9-438a-b94c-251cc86bc99a

# export CONN_CONFIG=ibmvpc-br-sao-1-config
# export IMAGE_NAME=r042-92d1cd12-f014-4b9a-abf8-c5ca6494a9e5

# export CONN_CONFIG=ibmvpc-us-south-1-config
# export IMAGE_NAME=r006-9de77234-3189-42f8-982d-f2266477cfe0

# export CONN_CONFIG=ibmvpc-au-syd-1-config
# export IMAGE_NAME=r026-a8c25ce6-0ca1-43e9-9b41-411c6217b8b8

@jihoon-seo jihoon-seo added the hold Need to hold merge label Nov 8, 2021
@jihoon-seo jihoon-seo force-pushed the 211105_Add_support_for_IBM-VPC branch from a5bba35 to 619c6c6 Compare November 8, 2021 07:27
@jihoon-seo
Copy link
Member Author

force-push: br-sao-1 의 Image ID 에 오류가 있어서 수정했습니다.

@jihoon-seo jihoon-seo removed the hold Need to hold merge label Nov 8, 2021
@seokho-son
Copy link
Member

/lgtm

@github-actions github-actions bot added the lgtm This PR is acceptable by at least one reviewer label Nov 8, 2021
@seokho-son seokho-son merged commit ee3a5df into cloud-barista:main Nov 8, 2021
@seokho-son
Copy link
Member

감사합니다... ^^ @jihoon-seo

@jihoon-seo jihoon-seo deleted the 211105_Add_support_for_IBM-VPC branch November 8, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR is acceptable by at least one reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants