enabling 'missing' filter for gcp #8234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thisisshi @kapilt , The PR fails in format check, specifically "black --check tools/c7n_left". This PR didn't change anything on c7n_left. |
|
thanks for the pr, looks like some of the linters are failing on it, |
|
Noted, likely related to not pinning black, I’ll take a look, thanks
…On Wed, Feb 1, 2023 at 11:19 AM hiteshmck ***@***.***> wrote:
@thisisshi <https://github.com/thisisshi> @kapilt
<https://github.com/kapilt> , The PR fails in format check, specifically
"black --check tools/c7n_left". This PR didn't change anything on c7n_left.
Any clues why it might be failing ? there is another PR just before this
that failed this check as well.
—
Reply to this email directly, view it on GitHub
<#8234 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFJETUYES4A4TCF352HSDWVKEKVANCNFSM6AAAAAAUN47FNU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@kapilt @thisisshi Can you please merge this when you get a chance. Kapil approved this PR earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'missing' filter exists and works for AWS, but it doesn't work for GCP.
This PR is to enable that filter for GCP so we can use that filter in GCP policies as well.