docs - document gcp env vars explicitly along with noting workload federation #8606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkerrigan
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
lgtm, thanks 👍
I had some local overrides for CLOUDSDK_CORE_PROJECTfrom testing, and followed some doc breadcrumbs in an effort to find how that differs from GOOGLE_CLOUD_PROJECT. I eventually landed here: https://cloud.google.com/python/docs/reference/google-cloud-core/latest/config
Wonder if that link might be useful to show credential precedence, or if that's too much / too confusing
|
added the link, thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested workload identity federation, add notes to docs on the exact env vars we consume, now that gcp client sdks have stabilized on which they use/document, and update doc links on
service account auth.