Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support passing terraform.workspace name #225

Merged

Conversation

albertodonato
Copy link
Collaborator

No description provided.

Copy link
Contributor

@fwereade fwereade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks especially for fixing that var name

Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this, looks good to me 👍

Comment on lines -47 to +53
s, stop_on_hcl_error, debug, allow_downloads, num_var_paths, c_var_paths
path,
stop_on_hcl_error,
debug,
allow_downloads,
workspace,
num_var_paths,
c_var_paths,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the formatting + variable rename combo to be as valuable as the new param to be honest :)

@ajkerrigan ajkerrigan merged commit c8ee6f7 into cloud-custodian:main Dec 9, 2024
11 checks passed
@albertodonato albertodonato deleted the worskpace-name-option branch December 10, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants