-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hardened containers #327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides one comment this looks great. Nice job factoring out the image
fields. Thanks!
ci/audit-pipeline.yml
Outdated
aws_region: us-gov-west-1 | ||
tag: latest | ||
|
||
- name: registry-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it'll mess up the alphabetical order, let's put this one first so all subsequent images are pulled using our version of registry-image
. If you want, you could link to this explanation, but totally up to you: https://github.com/cloud-gov/container-scanning/blob/main/docs/harden-pipelines.md#implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the order, thanks James!
… hardened version
Changes proposed in this pull request:
image
key rather than needing to specify it in every yml fileThings to check
INFO
and debugging statements are written withlog.debug
or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
Updates the pipeline to use hardened images, including updating the built-in resources with our own hardened resource images