Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hardened containers #327

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Use hardened containers #327

merged 6 commits into from
Aug 28, 2023

Conversation

dandersonsw
Copy link
Contributor

@dandersonsw dandersonsw commented Aug 28, 2023

Changes proposed in this pull request:

  • Updates the pipeline to use currently available hardened images
  • Simplifies the pipeline code by creating a resource for the general-task image and referencing that resource using the image key rather than needing to specify it in every yml file
  • Updates yml files so they are all formatted the same

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Updates the pipeline to use hardened images, including updating the built-in resources with our own hardened resource images

@dandersonsw dandersonsw requested a review from a team August 28, 2023 15:09
Copy link

@jameshochadel jameshochadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides one comment this looks great. Nice job factoring out the image fields. Thanks!

aws_region: us-gov-west-1
tag: latest

- name: registry-image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it'll mess up the alphabetical order, let's put this one first so all subsequent images are pulled using our version of registry-image. If you want, you could link to this explanation, but totally up to you: https://github.com/cloud-gov/container-scanning/blob/main/docs/harden-pipelines.md#implementation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the order, thanks James!

@dandersonsw dandersonsw added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit 52282ef Aug 28, 2023
@dandersonsw dandersonsw deleted the use-hardened-containers branch August 28, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants