Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database storage sizes for gp3 #334

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Update database storage sizes for gp3 #334

merged 4 commits into from
Sep 18, 2023

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Sep 18, 2023

Changes proposed in this pull request:

  • Update default storage for all database plans to 20 GB to support gp3 storage volumes
  • Update storage for internal databases to 20 GB to support gp3 storage volumes
  • Fix unit tests

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just updating storage sizes to support gp3 storage volumes

@markdboyd markdboyd requested a review from a team September 18, 2023 15:32
@markdboyd markdboyd added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 6939ea3 Sep 18, 2023
2 checks passed
@markdboyd markdboyd deleted the fix-pipeline branch September 18, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants