Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting enable_functions for mysql databases on upgrade #338

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Currently, we allow users to set enable_functions when creating new MySQL databases, but not when updating them. So users with existing MySQL databases can't enable this feature without creating a new database and importing a backup into it.

This PR enables the ability to set enable_functions when updating a database service, so customers with existing MySQL databases can easily enable this feature.

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just exposing an option on update that is already exposed on creation

@markdboyd markdboyd requested a review from a team September 29, 2023 19:08
Copy link
Contributor

@dandersonsw dandersonsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Mark!

@markdboyd markdboyd added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit c00f209 Sep 29, 2023
1 check passed
@markdboyd markdboyd deleted the allow-update-enable-functions branch September 29, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants