Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

true up prod internal db version #379

Merged
merged 1 commit into from
Sep 26, 2024
Merged

true up prod internal db version #379

merged 1 commit into from
Sep 26, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • see title

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@markdboyd markdboyd requested a review from a team as a code owner September 26, 2024 19:36
@markdboyd markdboyd added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 5ee8b12 Sep 26, 2024
1 check passed
@markdboyd markdboyd deleted the update-prod-internal-db-version branch September 26, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengerman13 bengerman13 bengerman13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdboyd @bengerman13