Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reset TOTP script to better handle usernames with single quotes #325

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • update reset TOTP script to better handle usernames with single quotes
  • apply Shellcheck suggestions

security considerations

I'm not sure if there are any risks to this way of passing escaped PostgreSQL parameters to the script that would allow for SQL or query injection. In theory, this script can only be run by operators on our database.

@markdboyd markdboyd requested a review from a team as a code owner July 31, 2024 18:26
@markdboyd markdboyd merged commit 489cc91 into main Jul 31, 2024
1 check passed
@markdboyd markdboyd deleted the handle-single-quotes-reset-totp branch July 31, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants