Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests #106

Merged
merged 99 commits into from
Mar 25, 2024
Merged

Fix e2e tests #106

merged 99 commits into from
Mar 25, 2024

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Mar 15, 2024

Changes proposed in this pull request:

Fixes #97
Closes https://github.com/cloud-gov/private/issues/920

  • Reduce number of instances of proxy application to 1. With more than one instance of the proxy application in use, session state was not properly sychronized across the instances, so the tests would sometimes fail because depending on which instance was handling a proxied request, it might not recognize the authenticated session and the request would be rejected
  • Update test proxy to run with 4 workers and use the eventlet worker type
  • Update README notes on running tests
  • Add success/failure notifications to pipeline
  • Update pipeline to use hardened playwright-python image for e2e tests
  • Add enforcement of black formatting
  • Refactor seed script for e2e tests to better handle errors
  • Update e2e tests to use assertions with auto-retry built-in
  • Disable UI elements in OpenSearch Dashboards that only appear sometimes and cause e2e test flakiness
  • Update OpenSearch and OpenSearch Dashboards to use 2.12.0

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

No known direct security impact of these changes, just improving the overall reliability and testability of the authentication proxy that will be used for the new customer logs system

@markdboyd markdboyd requested a review from a team March 25, 2024 14:30
@markdboyd markdboyd marked this pull request as ready for review March 25, 2024 15:36
ci/config.yml Outdated Show resolved Hide resolved
@markdboyd markdboyd merged commit 58c5247 into main Mar 25, 2024
@markdboyd markdboyd deleted the fix-e2e-tests branch March 25, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI failures
2 participants