Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker build #108

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Fix docker build #108

merged 3 commits into from
Mar 25, 2024

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Mar 25, 2024 •
edited
Loading

Changes proposed in this pull request:

  • Refactor pipeline so docker images are built using the correct source code

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@markdboyd markdboyd requested a review from a team March 25, 2024 19:29
@markdboyd markdboyd enabled auto-merge (squash) March 25, 2024 19:29
@markdboyd markdboyd merged commit 15f022c into main Mar 25, 2024
3 checks passed
@markdboyd markdboyd deleted the fix-docker-build branch March 25, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcgottlieb rcgottlieb rcgottlieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdboyd @rcgottlieb