Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and refactor e2e tests #82

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Fix and refactor e2e tests #82

merged 2 commits into from
Nov 17, 2023

Conversation

markdboyd
Copy link
Contributor

Related to #66

Changes proposed in this pull request:

  • Refactor e2e tests to use updated Playwright helper methods
  • Update e2e tests to rely less on CSS identifiers in favor of element text that may be more durable/reliable

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Making sure the e2e tests are passing is a critical piece of ensuring that this authentication proxy for Opensearch works as expected and guaranteeing tenant isolation of data

@markdboyd markdboyd requested a review from a team November 17, 2023 20:34
@markdboyd markdboyd merged commit 1d6cf1c into main Nov 17, 2023
1 check passed
@markdboyd markdboyd deleted the fix-e2e-tests branch November 17, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants