Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix networking script #83

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix networking script #83

merged 1 commit into from
Nov 17, 2023

Conversation

markdboyd
Copy link
Contributor

Related to #66

Changes proposed in this pull request:

  • Remove harcoding of app names and use Credhub vars for app names
  • Remove app name hardcoding in CF networking script and interpolate app names received from environment variables

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Making sure the e2e tests are passing is a critical piece of ensuring that this authentication proxy for Opensearch works as expected and guaranteeing tenant isolation of data

@markdboyd markdboyd requested a review from a team November 17, 2023 21:16
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@markdboyd markdboyd merged commit 68ec092 into main Nov 17, 2023
1 check passed
@markdboyd markdboyd deleted the fix-networking-script branch November 17, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants