.github: Fix Rust version for release to 1.58 #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately Rust 1.59 produces binaries that segfault when compiled with musl-gcc wrappers. Which is exactly how we produce out aarch64 and musl binaries for the release. See: rust-lang/rust#95926 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
|
I'm not 100% sure if we are affected by this issue at the moment due to the complexity within the GH actions for cross building. As such I think it's a good precaution as we are heading into our release later this week. |
|
@rbradford You can also work around the problem by passing |
This is a good idea. |
likebreath
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately Rust 1.59 produces binaries that segfault when compiled
with musl-gcc wrappers. Which is exactly how we produce out aarch64 and
musl binaries for the release.
See: rust-lang/rust#95926
Signed-off-by: Rob Bradford robert.bradford@intel.com