Increase portability though existing Info trait #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rbradford
commented
Mar 10, 2023
rbradford
commented
- bootinfo: Use Option for address of RSDP
- coreboot: Make module inclusion architecture specific
- fdt: Make available the guest FDT table if necessary
- bootinfo: Reduce hardcoding of load address for kernel
- bootinfo: Include reference to memory layout
This is a nicer conditional check for the presence of the RSDP vs relying on zero. Further by storing the address in the FDT struct it the architecture specific code in the FDT boot info can be removed. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
The code in this module is implicitly x86-64 specific. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Some architectures still require the guest FDT table for booting the kernel. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
For the FDT case this is chosen by the architecture otherwise it uses the common x86-64 version. This removes the number of locations this is hardcoded and reduces architectural dependent code in the EFI execution path. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
By including a reference to the memory layout in the Info trait we can remove the need to hardcode the memory layout in the EFI execution code making it more portable. Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.