Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Clean up license notices and copyrights #256

Merged
merged 2 commits into from
Jun 24, 2023

Conversation

retrage
Copy link
Contributor

@retrage retrage commented Jun 11, 2023

This PR proposes:

  • Replace Apache license texts with SPDX license identifiers.
  • Add missing license and copyright notices.

Some of the code files originally written by @josephlr do not have copyright notices. I'd like to confirm this with him, as I'm not sure if these contributions were made as Google or individually.

Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage retrage requested review from rbradford and josephlr June 11, 2023 06:28
@rbradford
Copy link
Member

Thanks @retrage!

@@ -1,3 +1,6 @@
// SPDX-License-Identifier: Apache-2.0
// Copyright (C) 2020 Joe Richey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably more appropriate to assume Google copyright here as it was submitted under that email address.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment. Changed with commit 32c46d8.

This commit adds missing license notices and copyrighs for code written
by @josephlr.

Signed-off-by: Akira Moroo <retrage01@gmail.com>
@retrage retrage force-pushed the 2023-06-11-use-spdx branch from 3b28588 to 32c46d8 Compare June 23, 2023 08:28
@retrage retrage requested a review from rbradford June 23, 2023 08:28
@retrage retrage merged commit 81fe041 into cloud-hypervisor:main Jun 24, 2023
@retrage retrage deleted the 2023-06-11-use-spdx branch June 24, 2023 03:29
@josephlr
Copy link
Contributor

josephlr commented Sep 1, 2023

I'm sorry I missed this PR (I've moved to a new team at work and have been swamped). The Copyright is Google LLC.

Google's preferred policy on this is actually public: https://opensource.google/documentation/reference/patching#license_headers_and_copyright_notices

When contributing to third-party projects, Googlers do not need to add Google's copyright notice when authoring patches to existing files. Googlers should add Google's copyright notice (or a "The Project Authors" style copyright notice) to new files being added to the library if permitted by the project maintainers.

So either:

// SPDX-License-Identifier: Apache-2.0
// Copyright <year> Google LLC.

or

// SPDX-License-Identifier: Apache-2.0
// Copyright <year> The Rust Hypervisor Firmware Authors

would work for any files I created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants